Skip to content

bpo-18717: Add test for request.urlretrieve#29822

Open
180909 wants to merge 2 commits into
python:mainfrom
180909:fix-issue-18717
Open

bpo-18717: Add test for request.urlretrieve#29822
180909 wants to merge 2 commits into
python:mainfrom
180909:fix-issue-18717

Conversation

@180909
Copy link
Copy Markdown
Contributor

@180909 180909 commented Nov 28, 2021 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Nov 28, 2021
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 29, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 29, 2021
@mjehanzeb mjehanzeb mannequin mentioned this pull request Apr 10, 2022
Open
serhiy-storchaka
serhiy-storchaka requested changes Feb 28, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

urllib.request tests that use network should be in test_urllibnet.py or test_urllib2net.py. Or in test_urllib2_localnet.py if they only use the local network.

And the tests should be more complicated. See #62917 (comment) for my suggestions.

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Feb 28, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Apr 10, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka requested changes

Assignees

No one assigned

Labels

awaiting changes stale Stale PR or inactive for long period of time. tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@180909 @serhiy-storchaka @the-knights-who-say-ni @ezio-melotti @bedevere-bot